Add server settings with auth state #175
Merged
feedmeapples merged 1 commit intomainfrom Dec 28, 2021
Merged
Conversation
feedmeapples
requested review from
GiantRobots,
softwarecurator and
stevekinney
stevekinney
approved these changes
Dec 16, 2021
feedmeapples
force-pushed
the
auth-settings
branch
from
4488ca9 to
c967fc5
Compare
feedmeapples
force-pushed
the
auth-settings
branch
from
c967fc5 to
dc95a39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
/api/v1/settingsSign inbutton depending on auth settingrelated PR temporalio/ui-server#77
Why?
Removes unnecessary
Sign Inbutton when auth is disabledChecklist
Closes
How was this tested:
Load server with enabled and disabled auths
Validate the sign in button only shows up when auth.enabled = false
Any docs updates needed?